Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow definition of parameterized tests by subclassing TestSuite #13

Closed
wants to merge 6 commits into from
Closed

Allow definition of parameterized tests by subclassing TestSuite #13

wants to merge 6 commits into from

Conversation

jamesmyatt
Copy link
Collaborator

The main updates are to allow parameterized tests to be defined by subclassing TestSuite.
Some other minor updates such as extracting functions from TestRunDisplay into utilities directory. Note that this directory also needs to be added on the path.

Example of parametrized tests in tests\helper_classes\TestParameterizedSuite.

@psexton
Copy link
Owner

psexton commented Jan 22, 2016

Going to split this into multiple merges because this is such a large pull request:

13a. Change TestRunLogger.appendToLog from private to protected
13b. Extract display functions from TestRunDisplay
13c. Display extra information for MultipleErrors exception
13d. Move xml_io_tools
13e. Update tests readme (good catch on an munit mention I missed!)
13f. Add TestSuite subclassing

psexton pushed a commit that referenced this pull request Jan 22, 2016
Merge part of pull request #13 from Nzbuu/master
9617077 
13a: Allow subclasses of TestRunLogger to append to log
@psexton
Copy link
Owner

psexton commented Jan 22, 2016

13a: 👍

psexton pushed a commit that referenced this pull request Jan 22, 2016
Merge part of pull request #13 from Nzbuu/master
c1cde80 
13b: Extract display functions from TestRunDisplay
13c: Display extra information for MultipleErrors exception
@psexton
Copy link
Owner

psexton commented Jan 22, 2016

13b: 👍 📝 Moved new functions from src/utilities to src/+xunit
13c: 👍

@psexton
Copy link
Owner

psexton commented Jan 22, 2016

13d: 👎 Seems unnecessary to move them, unless we're moving them into a package and taking them out of the global namespace. (Which would be good, but would require bumping the semver to 5.0.0.)

psexton pushed a commit that referenced this pull request Dec 20, 2016
Merge part of pull request #13 from Nzbuu/master
7f352aa 
13e: Update tests readme
@psexton
Copy link
Owner

psexton commented Dec 20, 2016

13e: 👍

@psexton
Copy link
Owner

psexton commented Dec 20, 2016

13f: Will re-look at after merging #20.

@jamesmyatt
Copy link
Collaborator Author

I've rebased these changes so that this now only contains those listed as (13f) in #13 (comment)

psexton
psexton requested changes Jan 10, 2017
View reviewed changes
Copy link
Owner

@psexton psexton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there really a need to support the old folder-based class system?

@psexton
Copy link
Owner

psexton commented Jan 10, 2017

Rest of it looks fine, and tests pass as far back as I have installed.

@jamesmyatt
Copy link
Collaborator Author

jamesmyatt commented Jan 10, 2017 •
edited
Loading

Re: @-folders. These are still used a lot, including by Mathworks. So, I think that it's best to support it.

@jamesmyatt
Copy link
Collaborator Author

I'm going to close this and start a new one for just the TestSuite subclassing

@jamesmyatt jamesmyatt closed this Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psexton psexton psexton requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesmyatt @psexton